zabetak commented on PR #3606: URL: https://github.com/apache/hive/pull/3606#issuecomment-1252564642
I completely forgot that I commented under the PR for HIVE-26496; sorry about that. Many thanks for the clarification and preparing the follow-up! The fact that bucketId is not assigned in the constructor is not something that was caused by https://github.com/apache/hive/pull/3559; it was there before that so it is not really tight to HIVE-26496. This is a beneficial refactoring that makes sense with or without HIVE-26496 so it could have a JIRA on its own. Other than that I think it is fine to commit under the same JIRA id although I don't see this pattern very often in the project. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
