abstractdog commented on code in PR #3603:
URL: https://github.com/apache/hive/pull/3603#discussion_r976569506
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java:
##########
@@ -1196,11 +1199,13 @@ private void updateDatabaseProp(Connection dbConn,
String database,
}
closeStmt(pst);
if (query == null) {
- LOG.info("Database property: " + prop + " with value: " + propValue +
" already updated for db: " + database);
+ LOG.info("Database property: {} with value: {} already updated for db:
{}", prop, propValue, database);
return;
}
pst = sqlGenerator.prepareStmtWithParameters(dbConn, query,
Arrays.asList(propValue));
- LOG.debug("Updating " + prop + " for db: " + database + " <" +
query.replaceAll("\\?", "{}") + ">", propValue);
+ if (LOG.isDebugEnabled()) {
+ LOG.debug("Updating " + prop + " for db: " + database + " <" +
query.replaceAll("\\?", "{}") + ">", propValue);
Review Comment:
oh, makes sense, we replace a single char here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
