dengzhhu653 commented on code in PR #3605:
URL: https://github.com/apache/hive/pull/3605#discussion_r990886739
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/SerializationUtilities.java:
##########
@@ -228,6 +230,27 @@ public void setConf(Configuration conf) {
public Configuration getConf() {
return configuration;
}
+
+ @Override
+ public com.esotericsoftware.kryo.Registration getRegistration(Class type) {
Review Comment:
I think so, `getRegistration` is place for check whether an unregistered
class is encountered when `registrationRequired` is set to true:
https://github.com/EsotericSoftware/kryo/blob/master/src/com/esotericsoftware/kryo/Kryo.java#L552-L556
However we cannot simply enable `registrationRequired` for UDF
deserialization, as non-transient fields in the UDF are arbitrary, it's
difficult to confine the inputs.
Thank you for the review and comments!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
