pudidic commented on code in PR #3644:
URL: https://github.com/apache/hive/pull/3644#discussion_r1000168804
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplDumpTask.java:
##########
@@ -1254,6 +1273,7 @@ Long bootStrapDump(Path dumpRoot, DumpMetaData dmd, Path
cmRoot, Hive hiveDb)
// Get the counter to store the snapshots created & deleted at
source.
replSnapshotCount = new SnapshotUtils.ReplSnapshotCount();
}
+ ExportService exportService = new ExportService(conf);
Review Comment:
Please move the ExportService object creation higher than a database level.
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplDumpTask.java:
##########
@@ -1290,6 +1310,21 @@ Long bootStrapDump(Path dumpRoot, DumpMetaData dmd, Path
cmRoot, Hive hiveDb)
}
}
+ if (exportService != null && exportService.isExportServiceRunning())
{
Review Comment:
Please move the ExportService object creation higher than a database level.
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplDumpTask.java:
##########
@@ -952,6 +954,7 @@ private Long incrementalDump(Path dumpRoot, DumpMetaData
dmd, Path cmRoot, Hive
}
}
for(String matchedDbName : Utils.matchesDb(hiveDb,
work.dbNameOrPattern)) {
+ ExportService exportService = new ExportService(conf);
Review Comment:
Please move the ExportService object creation higher than a database level.
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplDumpTask.java:
##########
@@ -978,6 +981,22 @@ private Long incrementalDump(Path dumpRoot, DumpMetaData
dmd, Path cmRoot, Hive
LOG.debug(te.getMessage());
}
}
+
+ if (exportService != null && exportService.isExportServiceRunning())
{
Review Comment:
Please move the ExportService object creation higher than a database level.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
