deniskuzZ commented on code in PR #3317:
URL: https://github.com/apache/hive/pull/3317#discussion_r1004476395
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java:
##########
@@ -4461,17 +4464,21 @@ public static
ImmutablePair<VectorAggregationDesc,String> getVectorAggregationDe
VectorizationContext vContext)
throws HiveException {
- VectorizedUDAFs annotation =
- AnnotationUtils.getAnnotation(evaluator.getClass(),
VectorizedUDAFs.class);
- if (annotation == null) {
- String issue =
- "Evaluator " + evaluator.getClass().getSimpleName() + " does not
have a " +
- "vectorized UDAF annotation (aggregation: \"" + aggregationName +
"\"). " +
- "Vectorization not supported";
- return new ImmutablePair<VectorAggregationDesc,String>(null, issue);
+ Class<? extends VectorAggregateExpression>[] vecAggrClasses;
+ if (aggregationName.equals("ds_kll_sketch")) {
Review Comment:
could we create an enum for the supportedAggregationUdfs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
