scarlin-cloudera commented on code in PR #3706:
URL: https://github.com/apache/hive/pull/3706#discussion_r1006963441


##########
ql/src/test/results/clientpositive/llap/bucket_groupby.q.out:
##########
@@ -1753,9 +1753,9 @@ STAGE PLANS:
                   filterExpr: (ds = '103') (type: boolean)
                   Statistics: Num rows: 500 Data size: 89000 Basic stats: 
COMPLETE Column stats: COMPLETE
                   Top N Key Operator
-                    sort order: ++
-                    keys: key (type: string), value (type: string)
-                    null sort order: zz
+                    sort order: +
+                    keys: key (type: string)
+                    null sort order: z

Review Comment:
   Yeah, I was concerned about being too aggressive?  Just not sure how to keep 
the proper aggressiveness and keep the code simple.  
   
   Maybe I should file another Jira for this?  Or would you like this resolved 
in this patch?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to