deniskuzZ commented on code in PR #3745:
URL: https://github.com/apache/hive/pull/3745#discussion_r1020078483
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergSerDe.java:
##########
@@ -121,12 +122,14 @@ public void initialize(@Nullable Configuration
configuration, Properties serDePr
this.partitionColumns = ImmutableList.of();
// create table for CTAS
if (e instanceof NoSuchTableException &&
-
Boolean.parseBoolean(serDeProperties.getProperty(hive_metastoreConstants.TABLE_IS_CTAS)))
{
+
StringUtils.isNotBlank(serDeProperties.getProperty(hive_metastoreConstants.TABLE_IS_CTAS)))
{
Review Comment:
is not blank doesn't mean it's always true. why do we need this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
