ayushtkn commented on code in PR #3758:
URL: https://github.com/apache/hive/pull/3758#discussion_r1022434349
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/writer/HiveIcebergDeleteWriter.java:
##########
@@ -41,21 +41,28 @@
class HiveIcebergDeleteWriter extends HiveIcebergWriterBase {
private final GenericRecord rowDataTemplate;
+ private final boolean skipRowData;
HiveIcebergDeleteWriter(Schema schema, Map<Integer, PartitionSpec> specs,
FileWriterFactory<Record> writerFactory, OutputFileFactory fileFactory,
FileIO io,
- long targetFileSize) {
+ long targetFileSize, boolean skipRowData) {
super(schema, specs, io,
new ClusteredPositionDeleteWriter<>(writerFactory, fileFactory, io,
targetFileSize));
rowDataTemplate = GenericRecord.create(schema);
+ this.skipRowData = skipRowData;
}
@Override
public void write(Writable row) throws IOException {
Record rec = ((Container<Record>) row).get();
PositionDelete<Record> positionDelete =
IcebergAcidUtil.getPositionDelete(rec, rowDataTemplate);
int specId = IcebergAcidUtil.parseSpecId(rec);
- writer.write(positionDelete, specs.get(specId),
partition(positionDelete.row(), specId));
+ Record rowData = positionDelete.row();
+ if (skipRowData) {
+ // Set null as the row data as we intend to avoid writing the actual row
data in the delete file.
+ positionDelete.set(positionDelete.path(), positionDelete.pos(), null);
Review Comment:
That row content is required for the partition details below in the writer
`` partition(rowData, specId));``, so that we need anyway irrespective of
whether we write the data or not
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
