Noremac201 opened a new pull request, #3784: URL: https://github.com/apache/hive/pull/3784
This is a rebased version of https://github.com/apache/hive/pull/3534, ## What changes were proposed in this pull request? * Added a proto3 syntax Hive Metastore proto file that was based off the existing `hive_metastore.thrift` file. * It generally tries to follow grpc best practices, so there are some slight variations on thrift, for example enums, response types of response specific empty protos, snake_case. * Guava is updated to version 22, which is required for proto3/grpc for compiling the protos. As this is "new" API, the new grpc API doesn’t include the same method with different signature, i.e. get_databases(string db_id) is usurped by get_databases(GetDatabasesRequest request). ## Why are the changes needed? The proto file is necessary because in order to have native gRPC support in Hive Metastore, there needs to be gRPC equivalents of all the preexisting Thrift objects as well as method header definitions in gRPC for Thrift counterparts. ## Does this PR introduce any user-facing change? Not yet, while this will allow developers to use this proto to generate clients (i.e. in Impala) before full support for gRPC is added in Hive Metastore. ## How was this patch tested? No tests were added in this PR other than making sure that the proto file and pom.xml files compile without issues and checking the target/ directory for generated files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
