deniskuzZ commented on code in PR #3746:
URL: https://github.com/apache/hive/pull/3746#discussion_r1034435640
##########
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactionQueryBuilder.java:
##########
@@ -200,22 +207,22 @@ CompactionQueryBuilder setIsDeleteDelta(boolean
deleteDelta) {
* @param compactionType major or minor; crud or insert-only, e.g.
CompactionType.MAJOR_CRUD.
* Cannot be null.
* @param operation query's Operation e.g. Operation.CREATE.
- * @param resultTableName the name of the table we are running the operation
on
+ * @param insertOnly Inidicated if the table is not full ACID but
Insert-only (Micromanaged)
* @throws IllegalArgumentException if compactionType is null
*/
- CompactionQueryBuilder(CompactionType compactionType, Operation operation,
+ CompactionQueryBuilder(CompactionType compactionType, Operation operation,
boolean insertOnly,
String resultTableName) {
if (compactionType == null) {
throw new
IllegalArgumentException("CompactionQueryBuilder.CompactionType cannot be
null");
}
+ this.compactionType = compactionType;
this.operation = operation;
this.resultTableName = resultTableName;
- major = compactionType == CompactionType.MAJOR_CRUD
- || compactionType == CompactionType.MAJOR_INSERT_ONLY;
- crud =
- compactionType == CompactionType.MAJOR_CRUD || compactionType ==
CompactionType.MINOR_CRUD;
- minor = !major;
- insertOnly = !crud;
+ this.insertOnly = insertOnly;
+
+ if(CompactionType.REBALANCE.equals(compactionType) && insertOnly) {
Review Comment:
nit: space
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
