shameersss1 commented on code in PR #3807:
URL: https://github.com/apache/hive/pull/3807#discussion_r1034579395
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/parser/Filter.g:
##########
@@ -141,7 +141,11 @@ binOpExpression
(
(key = Identifier op = operator value = DateLiteral)
|
+ (key = Identifier op = operator keyword = KW_DATE value =
StringLiteral)
+ |
Review Comment:
@kasakrisz Consider the following case where string column value matches the
pattern of the date
create table test_date (a int) partitioned by (b string);
insert into table test_date partition(b='2020-20-20') values (1);
insert into table test_date partition(b='2015-08-09') values (1);
insert into table test_date partition(b='2016-08-09') values (1);
select * from test_date where date_c='2020-20-20';
Here '2020-20-20' would match the dateLiteral and hence will lead to string
predicate not being pushed down since the date string is not valid
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
