dengzhhu653 commented on code in PR #3137:
URL: https://github.com/apache/hive/pull/3137#discussion_r1039223978
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/StatObjectConverter.java:
##########
@@ -1064,6 +1118,9 @@ public static void
setFieldsIntoOldStats(ColumnStatisticsObj oldStatObj,
if (newDecimalStatsData.isSetBitVectors()) {
oldDecimalStatsData.setBitVectors(newDecimalStatsData.getBitVectors());
}
+ if (newDecimalStatsData.isSetHistogram()) {
+ oldDecimalStatsData.setHistogram(newDecimalStatsData.getHistogram());
+ }
Review Comment:
should also deal with date and timestamp type?
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/StatObjectConverter.java:
##########
@@ -1064,6 +1118,9 @@ public static void
setFieldsIntoOldStats(ColumnStatisticsObj oldStatObj,
if (newDecimalStatsData.isSetBitVectors()) {
oldDecimalStatsData.setBitVectors(newDecimalStatsData.getBitVectors());
}
+ if (newDecimalStatsData.isSetHistogram()) {
+ oldDecimalStatsData.setHistogram(newDecimalStatsData.getHistogram());
+ }
Review Comment:
Should also deal with date and timestamp type?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
