ayushtkn commented on code in PR #3626:
URL: https://github.com/apache/hive/pull/3626#discussion_r1042178119
##########
llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskCommunicator.java:
##########
@@ -403,9 +401,8 @@ public void indicateError(Throwable t) {
+ " appId=" +
currentQueryIdentifierProto.getApplicationIdString()
+ " dagId=" + currentQueryIdentifierProto.getDagIndex()
+ " to node " + node.getHost());
- if (!processSendError(t)) {
- callback.setError(null, t);
- }
+ processSendError(t);
Review Comment:
I meant like that method in the end reaches fetchtoken, and there we are
putting appid as null
Can we not propogate the appId from there and use it here
```
private synchronized void fetchToken() {
LOG.debug("Trying to fetch a new token...");
try {
Token<LlapTokenIdentifier> newToken =
tokenClient.withCurrentToken(new
Token<LlapTokenIdentifier>(token)).getDelegationToken(null); <-- Here, pass
appId instead of null
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
