shameersss1 commented on code in PR #3811:
URL: https://github.com/apache/hive/pull/3811#discussion_r1045174093
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/parser/ExpressionTree.java:
##########
@@ -456,19 +457,22 @@ private String getJdoFilterPushdownParam(int partColIndex,
boolean isIntegralSupported = canPushDownIntegral &&
canJdoUseStringsWithIntegral();
String colType = partitionKeys.get(partColIndex).getType();
// Can only support partitions whose types are string, or maybe integers
- // Date data type value is considered as string hence pushing down to
JDO.
+ // Date/Timestamp data type value is considered as string hence pushing
down to JDO.
if (!colType.equals(ColumnType.STRING_TYPE_NAME) &&
!colType.equals(ColumnType.DATE_TYPE_NAME)
+ && !colType.equals(ColumnType.TIMESTAMP_TYPE_NAME)
Review Comment:
I don't think colType can be null ever.
Ack.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
