cnauroth commented on PR #3815: URL: https://github.com/apache/hive/pull/3815#issuecomment-1363285388
> Thanx @cnauroth Sorry for coming back late, was stuck with couple of things. Almost looks good. Regarding: > > > This patch introduced support for DBCP as a connection pool for the metastore database. It also corrected HIkariCP configuration by changing a pooling type constant from "hikari" to "hikaricp". > > Why there is no HiveConf Changes? > > ``` > - "hikari.,"+ > + "hikaricp.," + > + "dbcp., > ``` @ayushtkn , no worries on delays, and thanks for catching that! For some reason, the `HiveConf` change was not included in the [HIVE-17317](https://issues.apache.org/jira/browse/HIVE-17317) commit (16e6b837d96050b0837086c8dd171c71d9c0bcee) even though it was present in the patch file attachment. It looks like that was later corrected in [HIVE-19486](https://issues.apache.org/jira/browse/HIVE-19486). I started my backport from the git commit, not the file attachment, so I missed this part. I have pushed up a change to correct this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
