SourabhBadhya commented on code in PR #3908:
URL: https://github.com/apache/hive/pull/3908#discussion_r1064398828
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java:
##########
@@ -1087,6 +1096,10 @@ public void abortTxn(AbortTxnRequest rqst) throws
NoSuchTxnException, MetaExcept
@RetrySemantics.Idempotent
public void abortTxns(AbortTxnsRequest rqst) throws MetaException {
List<Long> txnIds = rqst.getTxn_ids();
+ TxnErrorMsg txnErrorMsg = TxnErrorMsg.NONE;
Review Comment:
Changed default values in all places to `TxnErrorMsg.NONE`. Done.
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java:
##########
@@ -5088,12 +5102,13 @@ private int abortTxns(Connection dbConn, List<Long>
txnids,
* @throws SQLException
*/
private int abortTxns(Connection dbConn, List<Long> txnids, boolean
checkHeartbeat,
- boolean skipCount, boolean isReplReplayed)
+ boolean skipCount, boolean isReplReplayed, TxnErrorMsg
errorMsg)
throws SQLException, MetaException {
Statement stmt = null;
if (txnids.isEmpty()) {
return 0;
}
+ LOG.info("Trying to abort txns due to : {}", errorMsg);
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
