saihemanth-cloudera commented on code in PR #2:
URL: https://github.com/apache/hive-site/pull/2#discussion_r1065922607


##########
themes/hive/layouts/partials/features.html:
##########
@@ -0,0 +1,170 @@
+<!---
+  Licensed to the Apache Software Foundation (ASF) under one
+  or more contributor license agreements.  See the NOTICE file
+  distributed with this work for additional information
+  regarding copyright ownership.  The ASF licenses this file
+  to you under the Apache License, Version 2.0 (the
+  "License"); you may not use this file except in compliance
+  with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing,
+  software distributed under the License is distributed on an
+  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+  KIND, either express or implied.  See the License for the
+  specific language governing permissions and limitations
+  under the License. -->
+
+<features class="container text-style white-background">
+    <div>
+        <div class="row feature-intro">
+            <div class="row section-header-style">
+                <h2 class="section-header-text" style="text-align: 
center;">What is Hive?</h2>
+            </div>
+            <p>
+                Apache Hive is a distributed, fault-tolerant data warehouse 
system that enables analytics at a massive scale.
+                Hive Metastore(HMS) provides a central repository of metadata 
that can easily be analyzed to make informed,
+                data driven decisions, and therefore it is a critical 
component of many data lake architectures.
+
+                Hive is built on top of Apache Hadoop and supports storage on 
S3, adls, gs etc though hdfs.
+                Hive allows users to read, write, and manage petabytes of data 
using SQL.
+            </p>
+        </div>
+        <div class="row section-header-style">
+            <h2 class="section-header-text" style="text-align: center;">Key 
Features</h2>
+        </div>
+        <div class="row divs">
+            {{- partial "hs2terminal.html" . -}}
+            <div class="col-md feature-border">
+                <h2 class="topic-text-style">Hive-Server 2 (HS2)</h2>
+                <p>
+                    HS2 supports multi-client concurrency and authentication.
+                    It is designed to provide better support for open API 
clients like JDBC and ODBC.
+                </p>
+                <a href="{{ .Site.Params.features.hs2 }}" class="icon-block">
+                    <button class="custom-button feature-button-style" 
role="button">Learn More</button>
+                </a>
+            </div>
+        </div>
+
+        <div class="row divs">
+            <div class="col-md feature-border">
+                <h2 class="topic-text-style">Hive Metastore Server (HMS)</h2>
+                <p>
+                    The Hive Metastore (HMS) is a central repository of 
metadata for Hive tables and partitions in a relational database,
+                    and provides clients (including Hive, Impala and Spark) 
access to this information using the metastore service API.
+                    It has become a building block for data lakes that utilize 
the diverse world of open-source software, such as Apache Spark and Presto.
+                    In fact, a whole ecosystem of tools, open-source and 
otherwise, are built around the Hive Metastore, some of which this diagram 
illustrates.
+                </p>
+                <a href="{{ .Site.Params.features.hms }}" class="icon-block">
+                    <button class="custom-button feature-button-style" 
role="button">Learn More</button>
+                </a>
+            </div>
+            <div class="col-md">
+                <a href="{{ .Site.Params.features.hms }}">
+                    <img src="{{.Site.BaseURL}}/images/HMS.jpg" width="600" 
height="400"  alt="Apache Software Foundation"></a>
+                </a>
+            </div>
+        </div>
+
+        <div class="row divs">
+            <div class="col-md ">
+                <a href="{{ .Site.Params.features.acidTxn }}">
+                    <img src="{{.Site.BaseURL}}/images/hiveAcid.svg" 
width="300" height="300"  alt="Apache Software Foundation"></a>
+                </a>
+            </div>
+            <div class="col-md feature-border">
+                <h2 class="topic-text-style">Hive ACID</h2>
+                <p>
+                    Hive provides full acid support for ORC tables out and 
insert only support to all other formats.
+                </p>
+                <a href="{{ .Site.Params.features.acidTxn }}" 
class="icon-block">
+                    <button class="custom-button feature-button-style" 
role="button">Learn More</button>
+                </a>
+            </div>
+        </div>
+
+        <div class="row divs">
+            <div class="col-md feature-border">
+                <h2 class="topic-text-style">Hive Data Compaction</h2>
+                <p>
+                    Query-based and MR-based data compactions are supported 
out-of-the-box.
+                </p>
+                <a href="{{ .Site.Params.features.compactions }}" 
class="icon-block">
+                    <button class="custom-button feature-button-style" 
role="button">Learn More</button>
+                </a>
+            </div>
+            <div class="col-md">
+                {{- partial "compaction.html" . -}}
+            </div>
+        </div>

Review Comment:
   Was this comment addressed?



##########
themes/hive/layouts/partials/footer.html:
##########
@@ -0,0 +1,55 @@
+<!---
+  Licensed to the Apache Software Foundation (ASF) under one
+  or more contributor license agreements.  See the NOTICE file
+  distributed with this work for additional information
+  regarding copyright ownership.  The ASF licenses this file
+  to you under the Apache License, Version 2.0 (the
+  "License"); you may not use this file except in compliance
+  with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing,
+  software distributed under the License is distributed on an
+  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+  KIND, either express or implied.  See the License for the
+  specific language governing permissions and limitations
+  under the License. -->
+
+<footer class="black-background static-bottom" style="padding:30px">
+    <div class="row">
+        <div class="col-3">
+            <a href="{{ .Site.Params.apache.apacheURL }}">
+                <img src="{{.Site.BaseURL}}{{ .Site.Params.logo }}" 
width="270" height="100"  alt="Apache Software Foundation"></a>
+            </a>
+        </div>
+        <div class="col-9">
+            <p class="footer-text">Apache is a non-profit organization helping 
open-source
+                software projects released under the Apache
+                <a href="{{ .Site.Params.apache.license }}">license</a>
+                and managed with
+                <a href="{{ .Site.Params.apache.howItWorks }}">
+                    open governance</a> and
+                <a href="{{ .Site.Params.apache.privacyPolicy }}">
+                    privacy policy</a>. See upcoming
+                <a href="{{ .Site.Params.apache.apacheEvents }}">Apache 
Events</a>.
+                If you discover any
+                <a href="{{ .Site.Params.apache.security }}">security</a> 
vulnerabilities, please
+                report them privately. Finally,
+                <a href="{{ .Site.Params.apache.sponsors }}">thanks
+                </a> to the sponsors who
+                <a href="{{ .Site.Params.apache.donate }}">
+                    donate</a> to the Apache Foundation.
+            </p>
+        </div>
+
+
+    </div>
+    <div class="copyright row">
+        <a href="{{ .Site.BaseURL }}" style="color:grey">
+            {{ with .Site.Params.Apache.Copyright | default .Site.Title }} {{ 
. | safeHTML }} {{ end }}
+        </a>
+    </div>
+
+</footer>
+<script 
src="https://cdn.jsdelivr.net/npm/[email protected]/dist/js/bootstrap.bundle.min.js";
 
integrity="sha384-MrcW6ZMFYlzcLA8Nl+NtUVF0sA7MsXsP1UyJoMp4YLEuNSfAP+JcXn/tWtIaxVXM"
 crossorigin="anonymous"></script>

Review Comment:
   Is it safe to use which encryption algorithm is used in the HTML?



##########
themes/hive/layouts/partials/head.html:
##########
@@ -0,0 +1,41 @@
+<!---
+  Licensed to the Apache Software Foundation (ASF) under one
+  or more contributor license agreements.  See the NOTICE file
+  distributed with this work for additional information
+  regarding copyright ownership.  The ASF licenses this file
+  to you under the Apache License, Version 2.0 (the
+  "License"); you may not use this file except in compliance
+  with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing,
+  software distributed under the License is distributed on an
+  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+  KIND, either express or implied.  See the License for the
+  specific language governing permissions and limitations
+  under the License. -->
+<!DOCTYPE html>
+<html>
+    <head>
+
+        <meta charset="utf-8">
+        <meta http-equiv="X-UA-Compatible" content="IE=edge">
+        <meta name="viewport" content="width=device-width, initial-scale=1">
+        <meta name="description" content="">
+        <meta name="author" content="">
+        <title>{{ .Title }}</title>
+        <link rel="icon" href="/images/hive.svg" sizes="any" 
type="image/svg+xml">
+        <link rel="stylesheet" href="{{ .Site.BaseURL }}/css/hive-theme.css" />
+        <link rel="stylesheet" 
href="https://maxcdn.bootstrapcdn.com/font-awesome/4.4.0/css/font-awesome.min.css";>
+        <link 
href="https://cdn.jsdelivr.net/npm/[email protected]/dist/css/bootstrap.min.css"; 
rel="stylesheet" 
integrity="sha384-EVSTQN3/azprG1Anm3QDgpJLIm9Nao0Yz1ztcQTwFspd3yD65VohhpuuCOmLASjC"
 crossorigin="anonymous">

Review Comment:
   Same as above comment.



##########
themes/hive/layouts/partials/compaction.html:
##########
@@ -0,0 +1,28 @@
+<!---
+  Licensed to the Apache Software Foundation (ASF) under one
+  or more contributor license agreements.  See the NOTICE file
+  distributed with this work for additional information
+  regarding copyright ownership.  The ASF licenses this file
+  to you under the Apache License, Version 2.0 (the
+  "License"); you may not use this file except in compliance
+  with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing,
+  software distributed under the License is distributed on an
+  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+  KIND, either express or implied.  See the License for the
+  specific language governing permissions and limitations
+  under the License. -->
+
+<compaction class="col-md">
+    <div id="comp" data-termynal data-termynal data-ty-typeDelay="40" 
data-ty-lineDelay="700">
+        <span data-ty="input">jdbc:hive2://.../default>ALTER TABLE test 
COMPACT "MAJOR";</span>
+        <span data-ty>Done!</span>
+        <span data-ty="input">jdbc:hive2://.../default>ALTER TABLE test 
COMPACT "MINOR";</span>
+        <span data-ty>Done!</span>
+        <span data-ty="input">jdbc:hive2://.../default> SHOW 
COMPACTIONS;</span>
+    </div>
+<!--    <script  src="{{ .Site.BaseURL }}/js/termynal.js" 
data-termynal-container="#comp"></script>-->

Review Comment:
   Nit:  remove this commented line.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to