amansinha100 commented on code in PR #3934:
URL: https://github.com/apache/hive/pull/3934#discussion_r1067357268
##########
ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java:
##########
@@ -3122,7 +3117,19 @@ Seems much cleaner if each stmt is identified as a
particular HiveOperation (whi
}
return lockComponents;
}
-
+
+ private static LockType getLockTypeFromStorageHandler(WriteEntity output,
Table t) {
+ final HiveStorageHandler storageHandler =
Preconditions.checkNotNull(t.getStorageHandler(),
+ "Thought all the non native tables have an instance of storage
handler");
Review Comment:
'Thought' is misplaced here. Although this was in the original code too,
this should be rephrased..something like 'Non native tables should have an
instance of storage handler'.
##########
iceberg/iceberg-handler/src/test/queries/positive/mv_iceberg_orc2.q:
##########
@@ -22,3 +22,12 @@ select * from mat1;
explain cbo
select tbl_ice.b, tbl_ice.c from tbl_ice where tbl_ice.c > 52;
+
+insert into tbl_ice values (10, 'ten', 60);
Review Comment:
In addition to the INSERT test, can we add one for DELETE as well ? This
would need format-version=2 for the source table. Also, I assume v2 is
supported for the MV itself so having a sanity test where the MV is created
with format-version=2 would be useful to check no deadlocks occur in that case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
