deniskuzZ commented on PR #3915: URL: https://github.com/apache/hive/pull/3915#issuecomment-1380695921
> @tarak271 The change looks OK, my only concern here that with the introduction of the new config value, cleaner will stop working on existing clusters after the upgrade which can lead to ready for cleaning queue accumulation and performance issues. For backward compatibility I would suggest to set an empty/null default value for the new config, and if it's not explicitly set, enable/disable cleaner according to the value in metastore.compactor.initiator.on. This also should be reflected in the description. @tarak271 , @deniskuzZ what do you think? I don't think that's gonna work for the boolean evaluator. This change would require an update of HIVE documentation & config templates. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
