difin commented on code in PR #3833:
URL: https://github.com/apache/hive/pull/3833#discussion_r1072298943
##########
ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedTreeReaderFactory.java:
##########
@@ -224,7 +237,252 @@ private static void skipCompressedIndex(boolean
isCompressed, PositionProvider i
index.getNext();
}
- protected static class StringStreamReader extends StringTreeReader
+ public static class StringDictionaryTreeReaderHive extends TreeReader {
Review Comment:
Hi @ayushtkn, I agree with you. It is not ideal approach. Before
implementing this approach I did try to adapt Hive, but I didn't succeed to
find how Hive could be adapted to ORC-1060 changes because those changes are
inside internal implementation of Orc StringDictionaryTreeReader class. The API
of StringDictionaryTreeReader class remained the same.
I agree with you that this approach is not ideal and will backfire in future
when we try to upgrade and the changes in ORC depends on the ones which we
ditched, but Hive already heavily depends on internal ORC API by implementing
its own column readers on top of ORC and when upgrading to different ORC
version it is often required to make adaptations in Hive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
