pudidic commented on code in PR #3963: URL: https://github.com/apache/hive/pull/3963#discussion_r1082136015
########## ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplDumpTask.java: ########## @@ -865,6 +865,10 @@ private Long incrementalDump(Path dumpRoot, DumpMetaData dmd, Path cmRoot, Hive if (conf.getBoolVar(HiveConf.ConfVars.HIVE_REPL_FAILOVER_START)) { work.getMetricCollector().reportFailoverStart(getName(), metricMap, work.getFailoverMetadata()); } else { + int size = tablesForBootstrap.size(); + if(size > 0) { Review Comment: Please follow the coding convention with a whitespace after if. ########## itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationOptimisedBootstrap.java: ########## @@ -906,6 +912,82 @@ public void testOverwriteDuringBootstrap() throws Throwable { .verifyFailure(new String[]{"tnew_managed"}); } + @Test + public void testTblMetricRegisterDuringSecondCycleOfOptimizedBootstrap() throws Throwable{ Review Comment: Please follow the coding convention by adding a whitespace after Throwable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org