kasakrisz commented on code in PR #3868:
URL: https://github.com/apache/hive/pull/3868#discussion_r1082528799
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/views/MaterializedViewRewritingRelVisitor.java:
##########
@@ -127,7 +129,8 @@ public void visit(RelNode node, int ordinal, RelNode
parent) {
// If it is not a materialized view, we do not rewrite it
throw new ReturnedValue(false);
}
- if (containsAggregate &&
!AcidUtils.isFullAcidTable(hiveTable.getHiveTableMD())) {
+ fullAcidView = AcidUtils.isFullAcidTable(hiveTable.getHiveTableMD());
Review Comment:
It has. The change in this patch is just saves the result of the static
`AcidUtils.isFullAcidTable` call to a local varialble.
Anyway, I like the idea so I moved this check outside of this class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
