kasakrisz commented on code in PR #3891:
URL: https://github.com/apache/hive/pull/3891#discussion_r1083809135
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/RowResolver.java:
##########
@@ -81,7 +81,10 @@ public RowResolver() {
public void putExpression(ASTNode node, ColumnInfo colInfo) {
String treeAsString = node.toStringTree();
expressionMap.put(treeAsString, node);
- put("", treeAsString, colInfo);
+ if (!putInternal("", treeAsString, colInfo)) {
+ return;
+ }
+ colInfo.setAlias(treeAsString);
Review Comment:
Inverted since only one line moved into the If block but I think it is a
question code style. I try to avoid moving and indenting several lines into if
blocks when early return is an option.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
