veghlaci05 commented on code in PR #3955:
URL: https://github.com/apache/hive/pull/3955#discussion_r1084093568
##########
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java:
##########
@@ -118,20 +120,33 @@ public void run() {
singleRun.cancel(true);
executor.shutdownNow();
executor = getTimeoutHandlingExecutor();
+ err = true;
} catch (ExecutionException e) {
LOG.info("Exception during executing compaction", e);
+ err = true;
} catch (InterruptedException ie) {
// do not ignore interruption requests
return;
Review Comment:
At this point the thread will end for sure since we are exiting the main
loop. If we restore the interrupted status, InterruptedException will be
re-thrown if the thread gets blocked by sleep/wait etc. I'm not sure about it,
but the msc.close() call in the finally block may result in an
InterruptedException if the threads needs to wait for sth during closing the
Thrift client.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
