deniskuzZ commented on code in PR #3822:
URL: https://github.com/apache/hive/pull/3822#discussion_r1085202881
##########
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java:
##########
@@ -613,13 +614,22 @@ private boolean isEligibleForCompaction(CompactionInfo ci,
return false;
}
- if (isNoAutoCompactSet(t.getParameters())) {
- LOG.info("Table " + tableName(t) + " marked " +
hive_metastoreConstants.TABLE_NO_AUTO_COMPACT +
- "=true so we will not compact it.");
+ Map<String, String> dbParams = computeIfAbsent(ci.dbname, () ->
resolveDatabase(ci)).getParameters();
+ if (isNoAutoCompactSet(dbParams, t.getParameters())) {
+ if (MetaStoreUtils.IS_DB_LEVEL_CONFIG) {
Review Comment:
idea is good , but not the impl. There could be multiple dbs, sharing
through static filed in multiple threads is not a good idea. What if you simple
use
````
if (getNoAutoCompact(dbParameters)){
skipDBs.add(ci.dbname);
} else {
skipTables.add(ci.getFullTableName());
}
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
