InvisibleProgrammer commented on code in PR #3986:
URL: https://github.com/apache/hive/pull/3986#discussion_r1090296761
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java:
##########
@@ -4397,9 +4397,9 @@ public static Operator<? extends OperatorDesc>
vectorizeFilterOperator(
vContext, vectorFilterDesc);
}
- private static Operator<? extends OperatorDesc> vectorizeTopNKeyOperator(
- Operator<? extends OperatorDesc> topNKeyOperator, VectorizationContext
vContext,
- VectorTopNKeyDesc vectorTopNKeyDesc) throws HiveException {
+ public static Operator<? extends OperatorDesc> vectorizeTopNKeyOperator(
Review Comment:
To be able to test the class. I used the same pattern as
`VectorFilterOperator` has. You can see the example in
`TestVectorFilterOperator.getAVectorFilterOperator`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
