abstractdog commented on code in PR #3983:
URL: https://github.com/apache/hive/pull/3983#discussion_r1091974491
##########
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:
##########
@@ -6322,29 +6322,67 @@ public ZooKeeperHiveHelper getZKConfig() {
.trustStorePassword(trustStorePassword).build();
}
+ public static HiveConf create() {
+ return new HiveConf();
+ }
+
+ public static HiveConf create(Class<?> cls) {
+ return new HiveConf(cls);
+ }
+
+ public static HiveConf create(Configuration other, Class<?> cls) {
+ return new HiveConf(other, cls);
+ }
+
+
+ public static HiveConf create(HiveConf other) {
+ return new HiveConf(other);
+ }
+
+ /**
+ * Instantiating HiveConf is deprecated. Please use
+ * HiveConf#create() to construct a Configuration,
+ * this method will become private eventually.
Review Comment:
yeah, I was thinking about the same, and just for curiosity's sake: if
nothing is broken with private (or protected) constructors, can we make the
public -> private/protected step in this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
