TaoZex commented on PR #3982: URL: https://github.com/apache/hive/pull/3982#issuecomment-1414018630
> Please consider adding the following test cases - > > 1. Null and empty string input > 2. Null, empty and Invalid "from" character set input > 3. Null, empty and Invalid "to" character set input > 4. 1/2 arguments given for convertCharset() UDF. > > For the cases which throw an exception - Consider writing negative test cases using TestNegativeLlapLocalCliDriver or by writing Junit tests. This is a good idea, I will modify the code according to your suggestion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
