ayushtkn commented on code in PR #4009:
URL: https://github.com/apache/hive/pull/4009#discussion_r1095010784
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java:
##########
@@ -12025,7 +12025,9 @@ private List<SQLPrimaryKey>
getPrimaryKeysInternal(final String catName,
final String
db_name_input,
final String
tbl_name_input)
throws MetaException, NoSuchObjectException {
- final String db_name = normalizeIdentifier(db_name_input);
+ final String db_name = StringUtils.isNotBlank(db_name_input) ?
Review Comment:
>what about fixing this in normalizeIdentifier instead?
This backfired 😅
This method is widely used, has some 500+ usage and some tests explicitly
asks for an NPE which later gets converted to MetaException, because of this it
doesn't fail here rather in the end fails with NoSuchObjectException in many
cases.
Reverting back to original for now to fix this only
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
