deniskuzZ commented on code in PR #3576:
URL: https://github.com/apache/hive/pull/3576#discussion_r1097065723
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/CompactionTxnHandler.java:
##########
@@ -1577,24 +1590,20 @@ public long findMinTxnIdSeenOpen() throws MetaException
{
}
minOpenTxn = rs.getLong(1);
if (rs.wasNull()) {
- minOpenTxn = -1L;
+ minOpenTxn = Long.MAX_VALUE;
Review Comment:
nope, per javaDoc wasNull reports whether the last column read had a value
of SQL <code>NULL</code>. You must first call one of the getter methods on a
column to try to read its value and then call the method <code>wasNull</code>
to see if the value read was SQL <code>NULL</code>.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]