kasakrisz commented on PR #4014: URL: https://github.com/apache/hive/pull/4014#issuecomment-1418713588
@yigress Your patch looks good to me but I have some comments: 1. Could you please check if the 26 failing test caused by this patch? 2. Have you tested whether the table is dropped in case of any error while executing the query in the ctas statement or cancelled by the user? In case of Iceberg it is handled by [HiveIcebergQueryLifeTimeHook]( https://github.com/apache/hive/blob/513127dd7793bee5caccbd266aa81d6bf6299902/iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergQueryLifeTimeHook.java#L60) and set via ``` set hive.query.lifetime.hooks=org.apache.iceberg.mr.hive.HiveIcebergQueryLifeTimeHook; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
