SourabhBadhya commented on code in PR #4098:
URL: https://github.com/apache/hive/pull/4098#discussion_r1128026739
##########
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/MetadataCache.java:
##########
@@ -17,32 +17,27 @@
*/
package org.apache.hadoop.hive.ql.txn.compactor;
-import com.google.common.cache.Cache;
-import com.google.common.cache.CacheBuilder;
+import com.github.benmanes.caffeine.cache.Cache;
+import com.github.benmanes.caffeine.cache.Caffeine;
import org.apache.thrift.TBase;
-import java.util.concurrent.Callable;
-import java.util.concurrent.ExecutionException;
+import java.util.function.Function;
public class MetadataCache {
private Cache<String, TBase> metaCache;
public MetadataCache(boolean tableCacheOn) {
if (tableCacheOn) {
- metaCache = CacheBuilder.newBuilder().softValues().build();
+ metaCache = Caffeine.newBuilder().softValues().build();
}
}
- public <T extends TBase<T,?>> T computeIfAbsent(String key, Callable<T>
callable) throws Exception {
+ public <T extends TBase<T,?>> T computeIfAbsent(String key, Function<? super
String, ? extends TBase> function) throws Exception {
if (metaCache != null) {
- try {
- return (T) metaCache.get(key, callable);
- } catch (ExecutionException e) {
- throw (Exception) e.getCause();
- }
Review Comment:
ThrowingFunction is no more required. Added the definition of the function
within `computeIfAbsent`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
