veghlaci05 commented on code in PR #4091: URL: https://github.com/apache/hive/pull/4091#discussion_r1135347917
########## ql/src/test/org/apache/hadoop/hive/ql/txn/compactor/TestInitiatorWithAbortCleanupUsingCleaner.java: ########## @@ -0,0 +1,28 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hive.ql.txn.compactor; + +import org.apache.hadoop.hive.metastore.conf.MetastoreConf; + +public class TestInitiatorWithAbortCleanupUsingCleaner extends TestInitiator { + @Override + public void setup() throws Exception { + super.setup(); + MetastoreConf.setBoolVar(conf, MetastoreConf.ConfVars.COMPACTOR_CLEAN_ABORTS_USING_CLEANER, true); Review Comment: It should be done the other way around: you should set it false here and rename the class to TestInitiatorWithAbortCleanupUsingHandler or sth similar. In the base class it will take the default value which is true. I suggest doing the same in the other class hierarchy as well (CompactorTest and descendants). For me, it is more straightforward that a descendant class where the only change is a config value should test the non-default value, rather than restore the default value which was set to sth else in the base class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
