SourabhBadhya commented on code in PR #4114: URL: https://github.com/apache/hive/pull/4114#discussion_r1135407734
########## ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java: ########## @@ -1538,9 +1537,9 @@ private static HdfsDirSnapshot addToSnapshot(Map<Path, HdfsDirSnapshot> dirToSna public static Map<Path, HdfsDirSnapshot> getHdfsDirSnapshots(final FileSystem fs, final Path path) Review Comment: Yeah the call hierarchy is true, but this is triggered only when the map is `null` in the `getAcidState()` call. In the case of Cleaner, the map of `HdfsDirSnapshots` is already created in prior and is used to call `getAcidState()`. Relevant code with the null condition -https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java#L1350-L1352 Other usecases of getting the acid state of a table might hit this codepath. But it seems like Cleaner will never hit this codepath. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
