deniskuzZ commented on code in PR #4131:
URL: https://github.com/apache/hive/pull/4131#discussion_r1148989152


##########
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:
##########
@@ -2207,6 +2207,8 @@ public static enum ConfVars {
         "Whether to use codec pool in ORC. Disable if there are bugs with 
codec reuse."),
     HIVE_USE_STATS_FROM("hive.use.stats.from","iceberg","Use stats from 
iceberg table snapshot for query " +
         "planning. This has three values metastore, puffin and iceberg"),
+    HIVE_COL_STATS_SOURCE("hive.col.stats.source","metastore","Use stats from 
puffin file for  query " +

Review Comment:
   - do we support `iceberg` mode? 
   - please update the description - "Use stats from the selected source for 
query planning" 
   
   what's the difference between `HIVE_USE_STATS_FROM` && 
`HIVE_COL_STATS_SOURCE `? it doesn't seem to be a generic config, should we add 
an ICEBERG prefix?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to