wecharyu commented on code in PR #4123:
URL: https://github.com/apache/hive/pull/4123#discussion_r1150092003


##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java:
##########
@@ -3101,6 +3100,22 @@ public boolean dropPartition(String catName, String 
dbName, String tableName,
     return success;
   }
 
+  @Override
+  public boolean dropPartition(String catName, String dbName, String 
tableName, String partName)
+      throws MetaException, NoSuchObjectException, InvalidObjectException, 
InvalidInputException {
+    boolean success = false;
+    try {
+      openTransaction();
+      dropPartitionsInternal(catName, dbName, tableName, 
Arrays.asList(partName), true, true);

Review Comment:
   We have some test for direct sql and jdo sql before, it shows direct sql is 
always faster even for simple operation like get connection. Let me add the 
benchmark for dropping multiple single partitions. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to