wecharyu commented on code in PR #4123:
URL: https://github.com/apache/hive/pull/4123#discussion_r1154494889
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java:
##########
@@ -5026,7 +5026,8 @@ private boolean drop_partition_common(RawStore ms, String
catName, String db_nam
verifyIsWritablePath(partPath);
}
- if (!ms.dropPartition(catName, db_name, tbl_name, part_vals)) {
+ String partName = Warehouse.makePartName(tbl.getPartitionKeys(),
part_vals);
+ if (!ms.dropPartition(catName, db_name, tbl_name, partName)) {
throw new MetaException("Unable to drop partition");
Review Comment:
`ms.dropPartition()` will throw the exception, we do not need to throw this
`MetaException` here, will remove this code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
