deniskuzZ commented on code in PR #4166:
URL: https://github.com/apache/hive/pull/4166#discussion_r1154631673
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/view/materialized/alter/rebuild/AlterMaterializedViewRebuildAnalyzer.java:
##########
@@ -465,21 +467,37 @@ private RelNode applyIncrementalRebuild(RelNode basePlan,
RelMetadataProvider md
protected ASTNode fixUpAfterCbo(ASTNode originalAst, ASTNode newAst,
CalcitePlanner.PreCboCtx cboCtx)
throws SemanticException {
ASTNode fixedAST = super.fixUpAfterCbo(originalAst, newAst, cboCtx);
+ if (mvRebuildMode == MaterializationRebuildMode.INSERT_OVERWRITE_REBUILD) {
+ return fixedAST;
+ } else if (mvRebuildMode ==
MaterializationRebuildMode.JOIN_INSERT_REBUILD) {
+ fixUpASTJoinInsertIncrementalRebuild(fixedAST);
+ return fixedAST;
+ }
+
+ MaterializedViewASTBuilder astBuilder;
+ if (AcidUtils.isFullAcidTable(mvTable.getTTable())) {
Review Comment:
please extract this into the helper method: getMaterializedViewASTBuilder()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
