deniskuzZ commented on code in PR #4155: URL: https://github.com/apache/hive/pull/4155#discussion_r1157388147
########## ql/src/java/org/apache/hadoop/hive/ql/ddl/table/convert/AlterTableConvertOperation.java: ########## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.hive.ql.ddl.table.convert; + + +import org.apache.hadoop.hive.ql.ddl.DDLOperationContext; +import org.apache.hadoop.hive.ql.ddl.table.AbstractAlterTableOperation; +import org.apache.hadoop.hive.ql.metadata.HiveException; +import org.apache.hadoop.hive.ql.metadata.Partition; +import org.apache.hadoop.hive.ql.metadata.Table; +import org.apache.hadoop.hive.ql.parse.SemanticException; + +import java.util.Map; + +/** + * Operation process of ALTER TABLE ... CONVERT command + */ +public class AlterTableConvertOperation extends AbstractAlterTableOperation<AlterTableConvertDesc> { + + private enum ConversionFormats { + ICEBERG("org.apache.iceberg.mr.hive.HiveIcebergStorageHandler"); + + private final String className; + + ConversionFormats(String className) { + this.className = className; + } + + public String className() { + return className; + } + } + + public AlterTableConvertOperation(DDLOperationContext context, AlterTableConvertDesc desc) { + super(context, desc); + } + + @Override + protected void doAlteration(Table table, Partition partition) throws HiveException { + // Add the covert type + String convertType = desc.getConvertSpec().getTargetType(); + ConversionFormats format = ConversionFormats.valueOf(convertType); + if (format.className().equalsIgnoreCase(table.getParameters().get("storage_handler"))) { Review Comment: could we please use constant instead of string literal -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
