rbalamohan commented on PR #4122: URL: https://github.com/apache/hive/pull/4122#issuecomment-1496750915
This is specific to JDK 9 issue. In recent JDKs it is back to the original implementation. i.e strictfp is removed and it is back to using Math.toDegrees in StrictMath. https://github.com/openjdk/jdk/commit/0ae4ceb413a7ea92a41cd55cd338f866098eb9b4 _Until we move to the latest JDK, it is fine to make this change._ Note that it will not have any difference in JDK 8 as well, since StrictMath::toDegrees uses Math::toDegrees/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
