abstractdog commented on code in PR #4121:
URL: https://github.com/apache/hive/pull/4121#discussion_r1158237604
##########
ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestOrcFile.java:
##########
@@ -1234,7 +1234,7 @@ public void emptyFile() throws Exception {
assertEquals(false, reader.rows().hasNext());
assertEquals(CompressionKind.NONE, reader.getCompression());
assertEquals(0, reader.getNumberOfRows());
- assertEquals(0, reader.getCompressionSize());
+ assertEquals(262144, reader.getCompressionSize());
Review Comment:
yay, very cool, nice catch!
so we had previously made a completely invalid assertion without a code
comment (without being aware that we're asserting based on an invalid behavior)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
