deniskuzZ commented on code in PR #4091:
URL: https://github.com/apache/hive/pull/4091#discussion_r1161662278


##########
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/handler/TaskHandler.java:
##########
@@ -81,4 +102,63 @@ protected Partition resolvePartition(String dbName, String 
tableName, String par
       return null;
     }
   }
+
+  protected ValidReaderWriteIdList getValidCleanerWriteIdList(AcidTxnInfo 
acidTxnInfo, ValidTxnList validTxnList)

Review Comment:
   should we rename this method to getValidWriteIdList?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to