difin commented on PR #4196: URL: https://github.com/apache/hive/pull/4196#issuecomment-1502008694
> Thanks @difin. LGTM. > > minor comment: Need to check if parameters with "$" (e.g java classnames) should be decoded. It can be a separate ticket. Hi @rbalamohan, I checked what happens when profiling a method with "$". From a command line the profiling command works if you escape the dollar sign by adding "\" before "$" : `curl "http://localhost:10002/prof?output=tree&duration=30&interval=1&method=java.util.concurrent.locks.AbstractQueuedSynchronizer\$ConditionObject.awaitNanos"` Than it generates an output file with name like this: `async-prof-pid-73790-java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.awaitNanos-4.tree` To open it in a linux shell the file also needs to be escaped. [async-prof-pid-73790-java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.awaitNanos-4.tree.html.txt](https://github.com/apache/hive/files/11191887/async-prof-pid-73790-java.util.concurrent.locks.AbstractQueuedSynchronizer.ConditionObject.awaitNanos-4.tree.html.txt) The output inside the output file is fine. A sample output file is attached. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
