kasakrisz commented on PR #4272: URL: https://github.com/apache/hive/pull/4272#issuecomment-1525549613
@aturoczy I agree. But this one is just 972 lines :) Look at `SemanticAnalyzer`. I'm not aware of any ongoing or planned refactor. Since one of the inputs of these methods is a query plan writing unit tests requires some plan generating logic which gives us the ability to define plans in an easily understand way. For example * calling the parser and compiler on a test sql * or implement utility methods to build a Hive operator tree similar to Calcite `RelBuilder`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
