difin commented on code in PR #4254:
URL: https://github.com/apache/hive/pull/4254#discussion_r1179603252
##########
itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreBeeLineDriver.java:
##########
@@ -97,6 +101,8 @@ public CoreBeeLineDriver(AbstractCliConfig testCliConfig) {
initScript = new File(testScriptDirectory,
testCliConfig.getInitScript());
}
cleanupScript = new File(testScriptDirectory,
testCliConfig.getCleanupScript());
+ this.replaceHandler = new QTestReplaceHandler();
Review Comment:
As I understand form the code, QTestUtil can't be used as is because it
doesn't execute commands using beeline.
After digging into other drivers that use QTestUtil, I saw that QTestUtil
executes commands from q-files using ReExecDriver.java which lives in hive-ql
module, while CoreBeeLineDriver executes commands from q-files using
Beeline.java.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
