pvary commented on PR #4252: URL: https://github.com/apache/hive/pull/4252#issuecomment-1531191604
> @pvary , let me reflect on your writings one by one: > > > [* 333227fbd13821365cec1bdbfcb9314a239bea0f](c3232b664745ebf761b6a74f4c5b55cc48bfd209: Hive: Use EnvironmentContext instead of Hive Locks to provide transactional commits after HIVE-26882 - This is based on 333227fbd13821365cec1bdbfcb9314a239bea0f and fede493d59f17ff2bfc0744b296d90bd36130386. Has to be a parallel change on Hive/Impala and every writers of the Iceberg table, but fixes stability and enhances commit performance)c3232b664745ebf761b6a74f4c5b55cc48bfd209: Hive: Use EnvironmentContext instead of Hive Locks to provide transactional commits after [HIVE-26882](https://issues.apache.org/jira/browse/HIVE-26882) - This is based on 333227fbd13821365cec1bdbfcb9314a239bea0f and fede493d59f17ff2bfc0744b296d90bd36130386. Has to be a parallel change on Hive/Impala and every writers of the Iceberg table, but fixes stability and enhances commit performance > > That is a pretty cool change. I'm pretty sure it is worth porting. But I'm not sure if we have to port it during the 1.2.1 upgrade. What if I create a ticket to port it after we finish the 1.2.1 upgrade? This is the somewhat evil one, as if the feature is turned on, then it should happen for all of the writers at the same time (there are configs which makes it possible for all of the use-cases we were able to come up during the review rounds). > > fede493d59f17ff2bfc0744b296d90bd36130386 - Hive: Lock hardening (#6451) - makes sure that the Lock used by the Iceberg commit are cleared up... If you do not have stability issues with stuck Hive Locks then you might skip backporting it. > > That is the tricky and ugly one that concerns me the most: The `HiveTableOperations` class is almost 1000 lines long in the Hive repository and about 500 lines in the Iceberg one. This is just changes some of the retry mechanism. Hard to backport, but no other risk, definitely no compatibility concerns here. You might wanted to talk about c3232b664745ebf761b6a74f4c5b55cc48bfd209 when you mention interproject sync, but I think it is not strictly necessary because of the configuration possibilities. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
