deniskuzZ commented on code in PR #4249:
URL: https://github.com/apache/hive/pull/4249#discussion_r1184773121
##########
itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcGenericUDTFGetSplits.java:
##########
@@ -38,14 +38,16 @@
public class TestJdbcGenericUDTFGetSplits extends
AbstractTestJdbcGenericUDTFGetSplits {
@Test(timeout = 200000)
- @Ignore("HIVE-23394")
public void testGenericUDTFOrderBySplitCount1() throws Exception {
- super.testGenericUDTFOrderBySplitCount1("get_splits", new int[]{10, 1, 0,
2, 2, 2, 1, 10});
+ super.testGenericUDTFOrderBySplitCount1("get_splits", new int[] { 10, 5,
0, 2, 2, 2, 5 });
+ super.testGenericUDTFOrderBySplitCount1("get_llap_splits", new int[] { 12,
7, 1, 4, 4, 4, 7 });
}
+
@Test(timeout = 200000)
public void testGenericUDTFOrderBySplitCount1OnPartitionedTable() throws
Exception {
super.testGenericUDTFOrderBySplitCount1OnPartitionedTable("get_splits",
new int[]{5, 5, 1, 1, 1});
+
super.testGenericUDTFOrderBySplitCount1OnPartitionedTable("get_llap_splits",
new int[]{7, 7, 3, 3, 3});
Review Comment:
but they test diff UDFs, could we at least have separate test methods for
them?
````
testGetSplitsOrderBySplitCount1OnPartitionedTable
testGetLlapSplitsOrderBySplitCount1OnPartitionedTable
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
