kasakrisz commented on code in PR #4278:
URL: https://github.com/apache/hive/pull/4278#discussion_r1185253932
##########
ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java:
##########
@@ -3096,6 +3096,8 @@ Seems much cleaner if each stmt is identified as a
particular HiveOperation (whi
assert t != null;
if (AcidUtils.isTransactionalTable(t) && sharedWrite) {
compBuilder.setSharedWrite();
+ } else if (MetaStoreUtils.isNonNativeTable(t.getTTable())) {
+ compBuilder.setLock(getLockTypeFromStorageHandler(output, t));
Review Comment:
Yes, I think the function `AcidUtils.makeLockComponents()` has to be
reconsidered from Iceberg standpoint.
But I think that is beyond the scope of this patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
