rkirtir commented on code in PR #4297: URL: https://github.com/apache/hive/pull/4297#discussion_r1188462611
########## itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/TestWarehouseExternalDir.java: ########## @@ -44,114 +44,94 @@ import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertNotNull; import static org.junit.Assert.assertTrue; - +import org.apache.hadoop.hive.metastore.api.Database; import org.slf4j.Logger; import org.slf4j.LoggerFactory; +import org.apache.hadoop.hive.metastore.Warehouse; - [email protected]("HIVE-25266") public class TestWarehouseExternalDir { - private static final Logger LOG = LoggerFactory.getLogger(TestWarehouseExternalDir.class); + private static final Logger LOG = LoggerFactory.getLogger(TestWarehouseExternalDir.class); + + private static MiniHS2 miniHS2; + private static Hive db; - static MiniHS2 miniHS2; - static Hive db; - static Connection conn; + private static HiveConf conf; + private static Connection conn; Review Comment: Agree. Removed unnecessary conn creation and closed connection in afterTest() class -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
