zhangbutao commented on code in PR #4216:
URL: https://github.com/apache/hive/pull/4216#discussion_r1188764400
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/DDLUtils.java:
##########
@@ -217,4 +218,11 @@ public static void
setColumnsAndStorePartitionTransformSpecOfTable(
partCols.ifPresent(tbl::setPartCols);
}
}
+
+ public static void
validateTableIsIceberg(org.apache.hadoop.hive.ql.metadata.Table table)
Review Comment:
yep, it duplicates `HiveTableOperations.validateTableIsIceberg` as DDLTask
in`ql ` package can not import iceberg class.
I changed the thrown exception to` Not an iceberg table: %s (type=%s)` ,
this means the same thing as `HiveTableOperations.validateTableIsIceberg`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
